Re: [PATCH 1/2] ASoC: rt5682s: Add driver for ALC5682I-VS codec

[Bard liao <yung-chuan.liao@xxxxxxxxxxxxxxx>]

On 8/26/2021 4:09 PM, derek.fang@xxxxxxxxxxx wrote:
> +
> +static int is_sys_clk_from_plla(struct snd_soc_dapm_widget *w,
> +		struct snd_soc_dapm_widget *sink)
> +{
> +	struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm);
> +	struct rt5682s_priv *rt5682s = snd_soc_component_get_drvdata(component);
> +
> +	if ((rt5682s->sysclk_src == RT5682S_CLK_SRC_PLL1) ||
> +	    (rt5682s->sysclk_src == RT5682S_CLK_SRC_PLL2 &&
> +	     rt5682s->pll_comb == USE_PLLAB))


What about rt5682s->pll_comb == USE_PLLA?


> +		return 1;
> +
> +	return 0;
> +}
> +
> +static int is_sys_clk_from_pllb(struct snd_soc_dapm_widget *w,
> +		struct snd_soc_dapm_widget *sink)
> +{
> +	struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm);
> +	struct rt5682s_priv *rt5682s = snd_soc_component_get_drvdata(component);
> +
> +	if (rt5682s->sysclk_src == RT5682S_CLK_SRC_PLL2)


Should we also test rt5682s->pll_comb here?


> +		return 1;
> +
> +	return 0;
> +}