Hi Mark, On 2021/8/26 20:52, Mark Brown wrote:
On Thu, Aug 26, 2021 at 12:01:51PM +0800, Sugar Zhang wrote:+/* tx/rx ctrl lock */ +static DEFINE_SPINLOCK(lock); +Why is this a global and not part of the driver data? It's also not clear to me why this is a spinlock and not a mutex.
Yes, this should be moved into driver data, will do in v4. it's not allowed to sleep in this context, so use spinlock instead. -- Best Regards! 张学广/Sugar 瑞芯微电子股份有限公司 Rockchip Electronics Co., Ltd.
