Hi Shengjiu, On Thu, Aug 26, 2021 at 8:19 AM Shengjiu Wang <shengjiu.wang@xxxxxxx> wrote: > + rpmsg->soc_data = of_device_get_match_data(&pdev->dev); > + if (rpmsg->soc_data) { This check is not necessary, because rpmsg->soc_data is always non-NULL. Other than that: Reviewed-by: Fabio Estevam <festevam@xxxxxxxxx>