Hi,
On 8/25/21 2:25 PM, Peter Ujfalusi wrote:
> Marking the two jack gpio as static fixes the following Sparse errors:
> sound/soc/intel/boards/bytcr_rt5640.c:468:26: error: symbol 'rt5640_jack_gpio' was not declared. Should it be static?
> sound/soc/intel/boards/bytcr_rt5640.c:475:26: error: symbol 'rt5640_jack2_gpio' was not declared. Should it be static?
>
> Fixes: 9ba00856686ad ("ASoC: Intel: bytcr_rt5640: Add support for HP Elite Pad 1000G2 jack-detect")
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@xxxxxxxxxxxxxxx>
Thanks, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>
Regards,
Hans
> ---
> sound/soc/intel/boards/bytcr_rt5640.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c
> index 05667a33d919..a6e837290c7d 100644
> --- a/sound/soc/intel/boards/bytcr_rt5640.c
> +++ b/sound/soc/intel/boards/bytcr_rt5640.c
> @@ -465,14 +465,14 @@ static struct snd_soc_jack_pin rt5640_pins2[] = {
> },
> };
>
> -struct snd_soc_jack_gpio rt5640_jack_gpio = {
> +static struct snd_soc_jack_gpio rt5640_jack_gpio = {
> .name = "hp-detect",
> .report = SND_JACK_HEADSET,
> .invert = true,
> .debounce_time = 200,
> };
>
> -struct snd_soc_jack_gpio rt5640_jack2_gpio = {
> +static struct snd_soc_jack_gpio rt5640_jack2_gpio = {
> .name = "hp2-detect",
> .report = SND_JACK_HEADSET,
> .invert = true,
>
