Looks mostly good, minor comments below
On 8/24/21 8:21 AM, Mark Hsieh wrote:
> Configure adl_max98390_rt5682 to support the rt5682 headset codec and max98390 speaker
>
> BUG=b:191811888
> TEST=emerge-brya chromeos-kernel-5_10
I don't think we need this for upstream?
> +struct snd_soc_ops max_98390_ops = {
> + .hw_params = max_98390_hw_params,
> +};
this could be const. We didn't do it for previous codecs but that was a
miss. I'll send a patch for the max98373
> +extern struct snd_soc_ops max_98390_ops;
const
