On 2021-08-17 07:35, Takashi Iwai wrote:
On Mon, 16 Aug 2021 18:06:23 +0200,
David Henningsson wrote:
Well, now that we're about to release a kernel with support for rawmidi tstamp framing,
how about some alsa-lib support for it as well?
Sure, that's the missing piece.
But, could you give a bit more description to each patch?
Do you mean commit message?
I could just write this for patch 1/2 (i e, copy the doc section added
in the patch):
Optionally, incoming rawmidi bytes can be put inside a frame of type snd_rawmidi_framing_tstamp_t.
The main current benefit is that can enable in-kernel timestamping of incoming bytes, and that
timestamp is likely to be more precise than what userspace can offer.
Tstamp type framing requires a kernel >= 5.14 and a buffer size that is a multiple of
sizeof(snd_rawmidi_framing_tstamp_t). It is only available on input streams.
And this for patch 2/2:
Adds a "clock type" parameter to the "rawmidi" test program, that when
used and combined with -i (and -v to be useful), activates tstamp type
framing with the specified clock type.
I hope this description makes it possible for you to review the patch
content as well.
Thanks,
// David
