On 2021-08-13 5:11 PM, Pierre-Louis Bossart wrote:
This is an update on an earlier contribution from Heikki Krogerus The function device_add_properties() is going to be removed. Replacing it with software node API equivalents. Thanks for Hans de Goede and Andy Shevchenko for their comments, suggestions and Reviewed-by tags on GitHub. The review thread can be found at https://github.com/thesofproject/linux/pull/3041) v3 changes: Fixed nit-picks from Andy: label, return value, missing commas/periods. Added Andy's Reviewed-by tag v2 changes: feedback from Andy and Hans Better error handling Codec reference is kept until the .remove callback Remove bus search to find device v1 changes from Heikki's patches: Avoid the use of devm_ routines for Baytrail machine drivers.
While sof_sdw_* machine boards history shows these have been updated concurrently, the same cannot be said for other, older Intel boards. And thus, I'd advise to separate changes for each older board, here: bytcht_es8316, bytcr_rt5640 and bytcr_rt5651. You could even squash smaller changes so the number of patches isn't getting out of control.
If regression occurs in just one of them - even due to spelling error or unintended code line - revert will impact all the boards. In the past having separate patches for kbl_*, bdw_* and such saved a lot of trouble, especially given their history.
This is more of an suggestion than a blocker. Haven't found any code issues: Reviewed-by: Cezary Rojewski <cezary.rojewski@xxxxxxxxx> Regards, Czarek
