Hi, On Wed, Aug 11, 2021 at 8:04 AM Mark Brown <broonie@xxxxxxxxxx> wrote: > > On Wed, Aug 11, 2021 at 07:40:59AM -0700, Doug Anderson wrote: > > On Tue, Aug 10, 2021 at 9:24 PM Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote: > > > > Nit: Add newline here. > > > How strongly do you feel about it? I purposely left the newline off to > > try to tie the devm_add_action_or_reset() more closely to the > > devm_regulator_bulk_get(). I wanted to make it more obvious that the > > two of them were "together" and shouldn't be split up. That being > > said, it's no skin off my teeth to add a newline if everyone likes it > > better. ;-) > > TBH the newline looks off before I've got as far as reading the code. Fair 'nuff. v2 is posted with the blank line. https://lore.kernel.org/r/20210811081751.v2.1.I4a1d9aa5d99e05aeee15c2768db600158d76cab8@changeid/ -Doug