On 8/9/21 4:35 PM, Curtis Malainey wrote:
> Sparse warnings triggered truncating the IDs of some platform device
> tables. Unfortunately some of the IDs in the match tables were missed
> which breaks audio. The KBL change has been verified to fix audio, the
> CML change was not tested as it was found through grepping the broken
> changes and found to match the same situation in anticipation that it
> should also be fixed.
>
> Fixes: 94efd726b947 ("ASoC: Intel: kbl_da7219_max98357a: shrink platform_id below 20 characters")
> Fixes: 24e46fb811e9 ("ASoC: Intel: bxt_da7219_max98357a: shrink platform_id below 20 characters")
> Signed-off-by: Curtis Malainey <cujomalainey@xxxxxxxxxxxx>
> Tested-by: Matt Davis <mattedavis@xxxxxxxxxx>
Thanks Curtis, this is exactly what I suggested in my earlier review of
Lukasz Majczak's "[PATCH v1] ASoC: Intel: kbl_da7219_max98357a: fix
drv_name"
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
Sorry about these misses...
> ---
> sound/soc/intel/common/soc-acpi-intel-cml-match.c | 2 +-
> sound/soc/intel/common/soc-acpi-intel-kbl-match.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/intel/common/soc-acpi-intel-cml-match.c b/sound/soc/intel/common/soc-acpi-intel-cml-match.c
> index 42ef51c3fb4f..b591c6fd13fd 100644
> --- a/sound/soc/intel/common/soc-acpi-intel-cml-match.c
> +++ b/sound/soc/intel/common/soc-acpi-intel-cml-match.c
> @@ -75,7 +75,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_cml_machines[] = {
> },
> {
> .id = "DLGS7219",
> - .drv_name = "cml_da7219_max98357a",
> + .drv_name = "cml_da7219_mx98357a",
> .machine_quirk = snd_soc_acpi_codec_list,
> .quirk_data = &max98390_spk_codecs,
> .sof_fw_filename = "sof-cml.ri",
> diff --git a/sound/soc/intel/common/soc-acpi-intel-kbl-match.c b/sound/soc/intel/common/soc-acpi-intel-kbl-match.c
> index ba5ff468c265..741bf2f9e081 100644
> --- a/sound/soc/intel/common/soc-acpi-intel-kbl-match.c
> +++ b/sound/soc/intel/common/soc-acpi-intel-kbl-match.c
> @@ -87,7 +87,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_kbl_machines[] = {
> },
> {
> .id = "DLGS7219",
> - .drv_name = "kbl_da7219_max98357a",
> + .drv_name = "kbl_da7219_mx98357a",
> .fw_filename = "intel/dsp_fw_kbl.bin",
> .machine_quirk = snd_soc_acpi_codec_list,
> .quirk_data = &kbl_7219_98357_codecs,
>
