Re: [PATCH v3 13/20] ASoC: qdsp6: audioreach: add basic pkt alloc support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks Mark for the review,

On 04/08/2021 19:09, Mark Brown wrote:
On Tue, Aug 03, 2021 at 01:54:04PM +0100, Srinivas Kandagatla wrote:

+config SND_SOC_QDSP6_AUDIOREACH
+	tristate "SoC ALSA audio drives for Qualcomm QDSP AUDIOREACH Framework"
+	depends on QCOM_GPR
+	help
+	 To add support for Qualcomm QDSP6 AudioReach Audio Framework.
+	 This will enable sound soc platform specific audio drivers.
+	 This includes q6apm, q6prm and associated dai and clock drivers
+	 for DSP.
+

We're adding the Kconfig before we've added all the code so the thing
works?

These are compile tested, but as you said previously with other patches I can move these Kconfig changes to patch at end of the series.


  obj-$(CONFIG_SND_SOC_QDSP6) += qdsp6/
+obj-${CONFIG_SND_SOC_QDSP6_AUDIOREACH} += qdsp6/

This adds two different references to the qdsp6 subdirectory which feels
like there's something wrong...

I could have avoided this extra config by adding all audioreach configs under CONFIG_SND_SOC_QDSP6. Will fix that in next version.

--srini





[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux