On 7/30/21 6:59 AM, Lukasz Majczak wrote:
> platform_id for kbl_da7219_max98357a was shrunk for kbl_da7219_mx98357a,
> but the drv_name was changed for kbl_da7219_max98373. Tested on a
> Pixelbook (Atlas).
>
> Fixes: 94efd726b947 ("ASoC: Intel: kbl_da7219_max98357a: shrink platform_id below 20 characters")
> Cc: <stable@xxxxxxxxxxxxxxx> # 5.4+
> Reported-by: Cezary Rojewski <cezary.rojewski@xxxxxxxxx>
> Tested-by: Lukasz Majczak <lma@xxxxxxxxxxxx>
> Signed-off-by: Lukasz Majczak <lma@xxxxxxxxxxxx>
> ---
> sound/soc/intel/common/soc-acpi-intel-kbl-match.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/intel/common/soc-acpi-intel-kbl-match.c b/sound/soc/intel/common/soc-acpi-intel-kbl-match.c
> index ba5ff468c265..8cab91a00b1a 100644
> --- a/sound/soc/intel/common/soc-acpi-intel-kbl-match.c
> +++ b/sound/soc/intel/common/soc-acpi-intel-kbl-match.c
> @@ -87,7 +87,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_kbl_machines[] = {
> },
> {
> .id = "DLGS7219",
> - .drv_name = "kbl_da7219_max98357a",
> + .drv_name = "kbl_da7219_mx98357a",
that one is correct, that was a miss
> .fw_filename = "intel/dsp_fw_kbl.bin",
> .machine_quirk = snd_soc_acpi_codec_list,
> .quirk_data = &kbl_7219_98357_codecs,
> @@ -113,7 +113,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_kbl_machines[] = {
> },
> {
> .id = "DLGS7219",
> - .drv_name = "kbl_da7219_mx98373",
> + .drv_name = "kbl_da7219_max98373",
this one is wrong though? The correct name was already present, you're
reverting back to the wrong name.
there's another one that I missed, do you mind changing this as well?
soc-acpi-intel-cml-match.c: .drv_name = "cml_da7219_max98357a",
Should be "cml_da7219_mx98357a"
> .fw_filename = "intel/dsp_fw_kbl.bin",
> .machine_quirk = snd_soc_acpi_codec_list,
> .quirk_data = &kbl_7219_98373_codecs,
>
