Re: [PATCH 0/4] ALSA: scarlett2: note gen 3 support + fix four issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 22 Jul 2021 22:11:40 +0200,
Geoffrey D. Bennett wrote:
> 
> Hi Takashi,
> 
> In the sound-5.14-rc1 merge commit log the highlights included:
> "Scarlett2 mixer code fixes and enhancements". I think that the new
> support for Gen 3 devices is significant enough to be worth
> mentioning.
> 
> Can you add to the next update a note along the lines of "Support for
> Focusrite Scarlett Solo/2i2/4i4/8i6/18i8/18i20 Gen 3 audio interface
> proprietary mixer controls"?
> 
> This set of patches is relative to v5.14-rc2 and fixes four issues:
> 
> 1. The Mute/Dim/MSD Mode controls are missing the direction/function
> parts of the syntax of standard control names as per
> Documentation/sound/designs/control-names.rst
> 
> - This could be considered a breaking-stable change if someone is
>   relying on the Mute/Dim control names not changing. I think it's
>   unlikely to be a problem as this driver is still considered
>   experimental and not enabled by default, but if never changing
>   control names is important, then you can drop this patch.
> 
> 2. The Direct Monitor control on the 2i2 interface is an Enum, not a
> Switch.
> 
> - This changes a control name, but that control was only introduced in
>   v5.14-rc1, so not a problem to change it now.
> 
> 3. Fixes the mute status not being correctly read when the mute button
> is pressed.
> 
> - Not applicable for stable; those controls were introduced in
>   v5.14-rc1.
> 
> 4. Sends the correct notification on line out and speaker switching
> changes.
> 
> - Partly applicable to stable, but will need a separate patch.
> 
> Thanks,
> Geoffrey.
> 
> Geoffrey D. Bennett (4):
>   ALSA: scarlett2: Fix Mute/Dim/MSD Mode control names
>   ALSA: scarlett2: Fix Direct Monitor control name for 2i2
>   ALSA: scarlett2: Correct channel mute status after mute button pressed
>   ALSA: scarlett2: Fix line out/speaker switching notifications

Applied all four patches now.  Thanks.


Takashi



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux