On 7/22/21 12:06 AM, Mario Limonciello wrote:
> Nearly every boot with a Lenovo P14s is showing
> acp_pdm_mach acp_pdm_mach.0: snd_soc_register_card(acp) failed: -517
>
> This isn't useful to a user, especially as probing will run again.
> Downgrade the message to debug, and only show errors.
>
> CC: markpearson@xxxxxxxxxx
> Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>
Reviewed-by: Vijendar Mukunda <Vijendar.Mukunda@xxxxxxx>
> ---
> sound/soc/amd/renoir/acp3x-rn.c | 14 +++++++++-----
> 1 file changed, 9 insertions(+), 5 deletions(-)
>
> Changes from v1->v2:
> * Simplify down to one return line.
>
> diff --git a/sound/soc/amd/renoir/acp3x-rn.c b/sound/soc/amd/renoir/acp3x-rn.c
> index 306134b89a82..ed73da496744 100644
> --- a/sound/soc/amd/renoir/acp3x-rn.c
> +++ b/sound/soc/amd/renoir/acp3x-rn.c
> @@ -54,12 +54,16 @@ static int acp_probe(struct platform_device *pdev)
> snd_soc_card_set_drvdata(card, machine);
> ret = devm_snd_soc_register_card(&pdev->dev, card);
> if (ret) {
> - dev_err(&pdev->dev,
> - "snd_soc_register_card(%s) failed: %d\n",
> - acp_card.name, ret);
> - return ret;
> + if (ret != -EPROBE_DEFER)
> + dev_err(&pdev->dev,
> + "snd_soc_register_card(%s) failed: %d\n",
> + card->name, ret);
> + else
> + dev_dbg(&pdev->dev,
> + "snd_soc_register_card(%s) probe deferred: %d\n",
> + card->name, ret);
> }
> - return 0;
> + return ret;
> }
>
> static struct platform_driver acp_mach_driver = {
>
