On 7/21/21 12:00 AM, Pierre-Louis Bossart wrote: > >> diff --git a/sound/soc/amd/vangogh/acp5x.h b/sound/soc/amd/vangogh/acp5x.h >> index 2300e63534e7..c94ed8795b9c 100644 >> --- a/sound/soc/amd/vangogh/acp5x.h >> +++ b/sound/soc/amd/vangogh/acp5x.h >> @@ -74,9 +74,20 @@ >> #define I2S_MASTER_MODE_ENABLE 0x01 >> #define I2S_MASTER_MODE_DISABLE 0x00 >> >> +#define SLOT_WIDTH_8 0x08 >> +#define SLOT_WIDTH_16 0x10 >> +#define SLOT_WIDTH_24 0x18 >> +#define SLOT_WIDTH_32 0x20 > > nit-pick: it's not incorrect but is the hex notation necessary? Will fix it and post the new version > >> +#define TDM_ENABLE 1 >> +#define TDM_DISABLE 0 >> +#define ACP5x_ITER_IRER_SAMP_LEN_MASK 0x38