Hi Heikki,
Going back to this initial patch, I have a doubt based on Andy Shevchenko's comment on an update [1]
> The function device_add_properties() is going to be removed.
> Replacing it with software node API equivalents.
The replacement pattern takes this one line:
> - ret = device_add_properties(sdw_dev, props);
which gets replaced by
> + fwnode = fwnode_create_software_node(props, NULL);
> + if (IS_ERR(fwnode)) {
> + return PTR_ERR(fwnode);
> }
>
> + ret = device_add_software_node(sdw_dev, to_software_node(fwnode));
> +
> + fwnode_handle_put(fwnode);
is the fwnode_handle_put() actually required here? This seems to work fine in our tests but I wasn't able to find in the code a matching _get().
Thanks for any pointers/comments!
-Pierre
[1] https://github.com/thesofproject/linux/pull/3041#discussion_r671450168
