Re: [PATCH 3/3] ASoC: wm_adsp: Remove pointless string comparison

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 28, 2021 at 05:58:37PM +0100, Mark Brown wrote:
> On Sat, Jun 26, 2021 at 04:59:41PM +0100, Charles Keepax wrote:
> 
> > The control fw_name is always directly assigned from the wm_adsp_fw_text
> > array, so it isn't necessary to compare the actual strings just the
> > pointer values.
> 
> This feels like it's asking for trouble in the future...

Thanks for applying anyway, apologies for my slow reply been off work.
We already have the same optimisation in other places so at least this
way its all broken in the same way if we hit an issue in the
future :-)

Thanks,
Charles



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux