On Fri, Jul 09, 2021 at 06:11:28PM -0500, David Rhodes wrote: > On 7/5/21 2:20 PM, Mark Brown wrote: > > > + case SND_SOC_DAPM_POST_PMD: > > > + regmap_read(cs35l41->regmap, CS35L41_PWR_CTRL1, &val); > > > + if (val & CS35L41_GLOBAL_EN_MASK) { > > > + regmap_update_bits(cs35l41->regmap, CS35L41_PWR_CTRL1, > > > + CS35L41_GLOBAL_EN_MASK, 0); > > I can't see any references to GLOBAL_EN outside this function, why might > > it not be set? > This check prevents an incorrect 'PDN Failed' message if DAPM initializes > and turns the widget off at boot (with no prior power-up). In what way does it prevent this message and why is this a good approach to the issue?
Attachment:
signature.asc
Description: PGP signature