On 7/7/21 9:52 PM, Mark Brown wrote:
> On Wed, Jul 07, 2021 at 11:26:15AM +0530, Vijendar Mukunda wrote:
>
>> +#define I2S_MODE 0x00
>> +#define ACP5x_I2S_MODE 0x00
>
> All the other constants are namespaced so why the plain I2S_MODE?
Already we have defined ACP5x_I2S_MODE to check whether ACP Audio mode
is set to I2S or not.
I2S_MODE macro to match one of the value of ACP_PIN_CONFIG which will be
programmed from BIOS based on Audio Configuration.
When few other audio modes added, will move ACP_PIN_CONFIG macro
definitions to enum.
>
>> + val = acp_readl(adata->acp5x_base + ACP_PIN_CONFIG);
>> + switch (val) {
>> + case I2S_MODE:
>
> ...
>
>> + break;
>> + default:
>> + dev_info(&pci->dev, "ACP audio mode : %d\n", val);
>> + }
>
> Given that anything other than I2S is basically unhandled should we
> perhaps print an error rather than just an info message
>
As mentioned above, ACP IP also supports other audio configurations.
When other audio configuration is selected, ACP PCI driver should be
loaded. see - efb38304c(ASoC: amd: support other audio modes for raven)
