On Fri, Jul 02, 2021 at 03:51:27PM -0500, David Rhodes wrote: > + cirrus,hw-noise-gate-select: > + description: Hardware Noise Gate feature. Each bit selects > + a different block for detection. > + 000000 - All noise gating functionality disabled > + xxxxx1 - Amplifier noise gating detection enabled > + xxxx1x - Boost converter DCM detection enabled > + xxx1xx - VMON low power mode detection enabled > + xx1xxx - IMON low power mode detection enabled > + x1xxxx - VP brownout prevention detection enabled > + 1xxxxx - VBST brownout prevention detection enabled > + type: boolean That description doesn't appear to be for a boolean field, either this should be a number of properties or it's not a boolean. It's also not clear to me that we shouldn't be able to control these features at runtime. > + cirrus,invert-pcm: > + description: > + Inverts the polarity of the audio signal output from > + the Class-D amplifier. > + type: boolean Given the potential confusion with the audio interface it might be better to call this invert-class-d or something.
Attachment:
signature.asc
Description: PGP signature
