> > > > > > swap wrt. spec: > > > sof_sdw_rt711.c: snd_jack_set_key(jack->jack, SND_JACK_BTN_0, > KEY_PLAYPAUSE); > > > sof_sdw_rt711.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_1, > KEY_VOICECOMMAND); > > > sof_sdw_rt711.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_2, > KEY_VOLUMEUP); > > > sof_sdw_rt711.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_3, > KEY_VOLUMEDOWN); > > > > > > kbl_rt5663_max98927.c: snd_jack_set_key(jack->jack, SND_JACK_BTN_0, > > > KEY_PLAYPAUSE); > > > kbl_rt5663_max98927.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_1, > > > KEY_VOICECOMMAND); > > > kbl_rt5663_max98927.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_2, > > > KEY_VOLUMEUP); > > > kbl_rt5663_max98927.c- snd_jack_set_key(jack->jack, SND_JACK_BTN_3, > > > KEY_VOLUMEDOWN); > > > > > > Brent, Curtis, Jimmy, can you comment on the order? > > > > Sorry for the late reply, I couldn't figure out why this slipped by my > > email filter, I guess I should look closer next time. Soraka has been > > checked (kbl_rt5663_max98927) and yes the mapping does appear to be > > incorrect, volume up key returns voice command in evtest. Sathya will > > have to check the headset button mapping, on rt711 but my guess is it > > is also incorrect. > > I stand corrected, misread the datasheet. So rt711 and rt5663 are correct > based on datasheet specs but when grabbing an off the shelf headphone they > did not work with the volume up. Hmm, I wonder if this split is "what usually > works" and "what is correct." Thanks for your reply, Curtis. This patch just changes the mapping to let the button function work properly. Hi Mark, Do I need to resend the patch? Or any comments? > ------Please consider the environment before printing this e-mail.