On Wed, Jun 16, 2021 at 06:56:25PM +0800, 班涛 wrote: > Hi, > > Maxime Ripard <maxime@xxxxxxxxxx> 于2021年6月16日周三 下午4:49写道： > > > > Hi, > > > > On Tue, Jun 15, 2021 at 09:07:37PM +0800, Ban Tao wrote: > > > The Allwinner SoCs feature an I2S controller across multiple SoC > > > generations. > > > > Which SoC generations? > > > > > Signed-off-by: Ban Tao <fengzheng923@xxxxxxxxx> > > > --- > > > .../sound/allwinner,sun50i-h6-dmic.yaml | 66 +++++++++++++++++++ > > > 1 file changed, 66 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml b/Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml > > > new file mode 100644 > > > index 000000000000..81d40c374e44 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/sound/allwinner,sun50i-h6-dmic.yaml > > > @@ -0,0 +1,66 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/sound/allwinner,sun50i-h6-dmic.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Allwinner H6 DMIC Controller Device Tree Bindings > > > + > > > +maintainers: > > > + - Ban Tao <fengzheng923@xxxxxxxxx> > > > + > > > +properties: > > > + "#sound-dai-cells": > > > + const: 0 > > > + > > > + compatible: > > > + const: allwinner,sun50i-h6-dmic > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + clocks: > > > + items: > > > + - description: Bus Clock > > > + - description: Module Clock > > > + > > > + clock-names: > > > + items: > > > + - const: apb > > > + - const: dmic > > > > The convention we use is bus and mod > > > > > + > > > + dmas: > > > + maxItems: 1 > > > + > > > + dma-names: > > > + const: rx > > > + > > > + resets: > > > + maxItems: 1 > > > + > > > +required: > > > + - "#sound-dai-cells" > > > + - compatible > > > + - reg > > > + - clocks > > > + - clock-names > > > + - dmas > > > + - dma-names > > > + - resets > > > + > > > +additionalProperties: false > > > + > > > +examples: > > > + - | > > > + spdif: spdif@5095000 { > > > > The label and node name seems wrong? > > > Yes, in fact, I don’t know much about yaml format files. > The allwinner,sun50i-h6-dmic.yaml file is based on > allwinner,sun4i-a10-spdif.yaml. > > So, How do i convert txt file to yaml file, for example: > --------------------------------------------- > Required properties: > > - compatible : should be one of the following: > - "allwinner,sun50i-h6-dmic": for the Allwinner H6 SoC > > - reg : physical base address of the > controller and length of memory mapped region. > > - dmas : Generic dma devicetree binding as described in > Documentation/devicetree/bindings/dma/dma.txt. > > - dma-names : DMA have to be defined, "rx". > > - clocks : Contains an entry for each entry in clock-names. > > - clock-names : Includes the following entries: > "apb" clock for the dmic bus. > "dmic" clock for dmic controller. > > - resets : reset specifier for the ahb reset > > Example: > > dmic: dmic@5095000 { > #sound-dai-cells = <0>; > compatible = "allwinner,sun50i-h6-dmic"; > reg = <0x05095000 0x400>; > clocks = <&ccu CLK_BUS_DMIC>, <&ccu CLK_DMIC>; > clock-names = "apb", "dmic"; > dmas = <&dma 7>; > dma-names = "rx"; > resets = <&ccu RST_BUS_DMIC>; > }; > --------------------------------------------- Just like you already did :) Aside from the few comments, what you did is spot on. Just remember to run make dt_binding_check after you wrote your schema Maxime
Attachment:
signature.asc
Description: PGP signature
