Re: [PATCH v2 2/4] ASoC: codecs: wcd: add multi button Headset detection support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 03/06/2021 13:44, Mark Brown wrote:
On Mon, May 24, 2021 at 12:06:58PM +0100, Srinivas Kandagatla wrote:

+		break;
+	default:
+		break;
+	}
+	return 0;
+}
+EXPORT_SYMBOL(wcd_mbhc_event_notify);

Why is this not EXPORT_SYMBOL_GPL?  Same for the other symbols that are
exported, between ASoC and regmap I'm not clear that there's anything
useful that is usable from non-GPL code...

This was not intentional, will fix this in next version.

+	/* Report insertion */
+	if (jack_type == SND_JACK_HEADPHONE)
+		mbhc->current_plug = MBHC_PLUG_TYPE_HEADPHONE;
+	else if (jack_type == SND_JACK_HEADSET) {
+		mbhc->current_plug = MBHC_PLUG_TYPE_HEADSET;
+		mbhc->jiffies_atreport = jiffies;
+	} else if (jack_type == SND_JACK_LINEOUT)
+		mbhc->current_plug = MBHC_PLUG_TYPE_HIGH_HPH;

This would be more idiomatically written as a switch statement.

I agree, I did try to keep it mostly in switch case, looks like I missed this one. Will change this in next spin.

--srini




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux