On 5/25/2021 12:18 PM, Takashi Iwai wrote: > On Tue, 25 May 2021 11:04:14 +0200, > Ujfalusi, Peter wrote: >> >> >> >> On 5/25/2021 11:23 AM, Takashi Iwai wrote: >>>>> Let's check other possibilities >>>>> at first, e.g. setting auto_mute_via_amp flag. This can be achieved >>>>> even via hints in an early patching specified via "patch" option of >>>>> snd-hda-intel module (see Documentation/sound/hda/notes.rst for some >>>>> information). >>>> >>>> Unfortunately the auto_mute_via_amp has no effect on the pop. >>>> line_in_auto_switch and pin_amp_workaround have no effect either. >>> >>> How about applying alc_fixup_no_shutup() or alc_fixup_disable_aamix()? >> >> it looks like >> >> SND_PCI_QUIRK(0x17aa, 0x1048, "Lenovo ThinkStation P340", >> ALC269_FIXUP_NO_SHUTUP), >> >> in alc269_fixup_tbl[] >> >> alone fixes the pop noise, I'll send a new patch to do this instead. > > Good to hear. > > But, there is already a quirk entry for this ID, so you'll need to put > a chain there instead, I suppose. Adding Hui Wang who added old fixup fir the mics. Oh, I see. It might be that the "ThinkCentre Station" is actually refers to "ThinkStation P340" in that case I wonder if the plock/pop can be observed by Hui Wang as well and confirm that it is the same model. do you have any suggestion on naming the chain for the P340 headset-mic and no-plop on lineout fixup enum/text/entry? -- Péter
