Hi, On Mon, 24 May 2021, Pierre-Louis Bossart wrote: > On 5/20/21 11:33 AM, Richard Fitzgerald wrote: > > Add select of SND_SOC_HDAC_HDMI for SND_SOC_INTEL_SOUNDWIRE_SOF_MACH. > > Without this the build results in missing references to > > hdac_hdmi_jack_port_init and hdac_hdmi_jack_init. > Kai, can you comment on this one? There is nothing specific to HDMI in this > driver. usage of hdac-hdmi is removed in newer mach drivers (like sof_da7219_max98373, sof-pcm512 and ehl_rt5660 -> and there's no select for SND_SOC_HDAC_HDMI for these). For older ones, we've kept hdac-hdmi in to keep compatibility. For sof_sdw, there are still calls to hdac_hdmi_jack_init() and friends in sof_sdw_hdmi.c, so this is a real problem. I'd say a better fix is that we remove the hdac-hdmi support from sof_sdw. I can do a patch for that. > Something's inconsistent here, it's not limited to SoundWire I am afraid I checked all the related mach drivers and the Kconfig definitions are correct for others. So select is done to HDAC_HDMI whenever the mach driver uses hdac_hdmi_jack_*(). Br, Kai
