Re: [PATCH] Fix a compile warning under gcc-4.2.3.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Joshua Roys wrote:> sound/core/init.c: In function ‘snd_card_disconnect’:> sound/core/init.c:307: warning: the address of ‘snd_shutdown_f_ops’ will always evaluate as ‘true’>> Signed-off-by: Joshua Roys <roysjosh@xxxxxxxxx>> --->  sound/core/init.c |    1 ->  1 files changed, 0 insertions(+), 1 deletions(-)>> diff --git a/sound/core/init.c b/sound/core/init.c> index 2cb7099..1afc58b 100644> --- a/sound/core/init.c> +++ b/sound/core/init.c> @@ -304,7 +304,6 @@ int snd_card_disconnect(struct snd_card *card)>  		list_add(&mfile->shutdown_list, &shutdown_files);>  		spin_unlock(&shutdown_lock);>> -		fops_get(&snd_shutdown_f_ops);>  		mfile->file->f_op = &snd_shutdown_f_ops;>  		>  		mfile = mfile->next;
This change may get rid of the warning, but is has the slightdisadvantage that the kernel will blow up if you try to unload the soundmodules before all device files have been closed.
If you want to get rid of this warning, tell the compiler that fops_getknows what it does; or try making fops_get an inline function instead ofa macro.

Regards,Clemens_______________________________________________Alsa-devel mailing listAlsa-devel@xxxxxxxxxxxxxxxxxxxx://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux