On Tue, 2021-05-18 at 20:01 +0100, Mark Brown wrote: > On Tue, May 18, 2021 at 10:41:21AM -0700, Ranjani Sridharan wrote: > > > BE hw_params op was recently added for SSP type DAIs. > > But sending the DAI_CONFIG IPC during hw_params > > is not supported with older firmware. So add an ABI check > > to avoid sending the IPC if the firmware ABI is older than > > 3.18. > > Should we warn if we were trying to configure something but weren't > able > to? Seems like something has got out of sync if we're trying to do > so. Hi Mark, A warning would be a bit misleading here. We added the BE hw_params for the SSP DAIs to be able to choose the right config based on runtime hw_params. But this is relevant only if there are multiple configs in the topology. With the older firmware, we do not support multiple config in topology, so what this would really end up doing is sending the same DAI config that was sent to the DSP during topology parsing again during BE hw_params. So it is safe to simply ignore it here. Thanks, Ranjani
