Hi, this is a patch series for usx2y drivers. Most part of changes are about cleanup of the code. The current usx2y driver is fairly unmaintained code, and this was the cause of some overseen bugs (or rather confusion) as happened in UMN fiasco. So the initial goal is to make a bit more readable for further reviews. The remaining part of changes are actual fixes. At this time, I concentrated only on the obvious issues that could be spotted out after the cleanup. The driver is likely broken in other ways, but the identification and the fix would need the actual device, so I leave them for now. Takashi === Takashi Iwai (11): ALSA: usx2y: Avoid camelCase ALSA: usx2y: Fix spaces ALSA: usx2y: Coding style fixes ALSA: usx2y: Fix potential leaks of uninitialized memory ALSA: usx2y: Avoid self-killing ALSA: usx2y: Fix potential memory leaks ALSA: usxy2: Fix potential doubly allocations ALSA: usx2y: Fix shmem initialization ALSA: usx2y: Don't call free_pages_exact() with NULL address ALSA: usx2y: Cleanup probe and disconnect callbacks ALSA: usx2y: Nuke pcm_list sound/usb/usx2y/us122l.c | 61 +-- sound/usb/usx2y/us122l.h | 2 +- sound/usb/usx2y/usX2Yhwdep.c | 135 +++--- sound/usb/usx2y/usX2Yhwdep.h | 2 +- sound/usb/usx2y/usb_stream.c | 82 ++-- sound/usb/usx2y/usb_stream.h | 23 +- sound/usb/usx2y/usbus428ctldefs.h | 104 ++--- sound/usb/usx2y/usbusx2y.c | 389 +++++++++-------- sound/usb/usx2y/usbusx2y.h | 65 ++- sound/usb/usx2y/usbusx2yaudio.c | 684 ++++++++++++++++-------------- sound/usb/usx2y/usx2yhwdeppcm.c | 627 ++++++++++++++------------- sound/usb/usx2y/usx2yhwdeppcm.h | 4 +- 12 files changed, 1146 insertions(+), 1032 deletions(-) -- 2.26.2