On Thu, May 13, 2021 at 4:07 AM Rob Herring <robh@xxxxxxxxxx> wrote: > > On Mon, May 10, 2021 at 03:07:21PM +0800, Shengjiu Wang wrote: > > Imx-akcodec is a new added machine driver for supporting > > ak4458/ak5558/ak5552/ak4497 codec on i.MX platforms. > > > > Signed-off-by: Shengjiu Wang <shengjiu.wang@xxxxxxx> > > --- > > changes in v2: > > - update doc accoring to Rob's comment, use the common porperties. > > > > .../bindings/sound/imx-audio-akcodec.yaml | 107 ++++++++++++++++++ > > 1 file changed, 107 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/sound/imx-audio-akcodec.yaml > > > > diff --git a/Documentation/devicetree/bindings/sound/imx-audio-akcodec.yaml b/Documentation/devicetree/bindings/sound/imx-audio-akcodec.yaml > > new file mode 100644 > > index 000000000000..0812c4779b59 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/sound/imx-audio-akcodec.yaml > > @@ -0,0 +1,107 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/sound/imx-audio-akcodec.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: NXP i.MX audio complex with AK4458/AK5558/AK5552/AK4497 codec > > + > > +maintainers: > > + - Shengjiu Wang <shengjiu.wang@xxxxxxx> > > + > > +properties: > > + compatible: > > + enum: > > + - fsl,imx8mq-audio-akcodec > > + - fsl,imx-audio-akcodec > > We gone from individual codecs to a family of codecs. Is there something > specific for the machine driver about this set of codecs? Why can't it > be *any* codec? Yes, there is something specific. but let me do further updates for this in the next version, then the document name needs to be changed to "imx-audio-card". best regards wang shengjiu
