On Thu, 06 May 2021 09:23:59 +0200, Hui Wang wrote: > > > On 5/4/21 4:30 PM, Takashi Iwai wrote: > > On Tue, 04 May 2021 09:39:17 +0200, > > Hui Wang wrote: > >> Without this change, the DAC ctl's name could be changed only when > >> the machine has both Speaker and Headphone, but we met some machines > >> which only has Lineout and Headhpone, and the Lineout and Headphone > >> share the Audio Mixer0 and DAC0, the ctl's name is set to "Front". > >> > >> On most of machines, the "Front" is used for Speaker only or Lineout > >> only, but on this machine it is shared by Lineout and Headphone, > >> This introduces an issue in the pipewire and pulseaudio, suppose users > >> want the Headphone to be on and the Speaker/Lineout to be off, they > >> could turn off the "Front", this works on most of the machines, but on > >> this machine, the "Front" couldn't be turned off otherwise the > >> headphone will be off too. Here we do some change to let the ctl's > >> name change to "Headphone+LO" on this machine, and pipewire and > >> pulseaudio already could handle "Headphone+LO" and "Speaker+LO". > >> (https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/747) > >> > >> BugLink: http://bugs.launchpad.net/bugs/804178 > >> Signed-off-by: Hui Wang <hui.wang@xxxxxxxxxxxxx> > > I'm fine to take the change, but wouldn't this break anything else in > > PA? Once when I get a positive answer, I'll apply it. > > I think this change is safe to PA, both "Headphone+LO" and > "Speaker+LO" are already in the analog-output-*.conf of PA. And I > raised the regression concern in the > https://gitlab.freedesktop.org/pipewire/pipewire/-/issues/747, all > participants of the discussion on that issue don't express objection > on this change so far. Fair enough, I applied it now. Thanks. Takashi
