Re: [PATCH] ASoC: rt711-sdca: fix the function number of SDCA control for feature unit 0x1E

[Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>]

On 5/4/21 5:04 AM, shumingf@xxxxxxxxxxx wrote:
> From: Shuming Fan <shumingf@xxxxxxxxxxx>
>
> The function number should be FUNC_NUM_MIC_ARRAY(0x2) for the feature unit 0x1E.
>
> Signed-off-by: Shuming Fan <shumingf@xxxxxxxxxxx>

This fixes the issue we saw, the test reports are fine with this patch. 
Thanks Shuming!

BugLink: https://github.com/thesofproject/linux/issues/2877
Fixes: ca5118c0c00f6 ('ASoC: rt711-sdca: change capture switch controls')

> ---
>   sound/soc/codecs/rt711-sdca.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/codecs/rt711-sdca.c b/sound/soc/codecs/rt711-sdca.c
> index cc36739f7fcf..24a084e0b48a 100644
> --- a/sound/soc/codecs/rt711-sdca.c
> +++ b/sound/soc/codecs/rt711-sdca.c
> @@ -683,13 +683,13 @@ static int rt711_sdca_set_fu1e_capture_ctl(struct rt711_sdca_priv *rt711)
>   	ch_r = (rt711->fu1e_dapm_mute || rt711->fu1e_mixer_r_mute) ? 0x01 : 0x00;
>   
>   	err = regmap_write(rt711->regmap,
> -			SDW_SDCA_CTL(FUNC_NUM_JACK_CODEC, RT711_SDCA_ENT_USER_FU1E,
> +			SDW_SDCA_CTL(FUNC_NUM_MIC_ARRAY, RT711_SDCA_ENT_USER_FU1E,
>   			RT711_SDCA_CTL_FU_MUTE, CH_L), ch_l);
>   	if (err < 0)
>   		return err;
>   
>   	err = regmap_write(rt711->regmap,
> -			SDW_SDCA_CTL(FUNC_NUM_JACK_CODEC, RT711_SDCA_ENT_USER_FU1E,
> +			SDW_SDCA_CTL(FUNC_NUM_MIC_ARRAY, RT711_SDCA_ENT_USER_FU1E,
>   			RT711_SDCA_CTL_FU_MUTE, CH_R), ch_r);
>   	if (err < 0)
>   		return err;