Re: [PATCH v5] sound: rawmidi: Add framing mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi David,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on sound/for-next]
[also build test WARNING on v5.12-rc7 next-20210416]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/David-Henningsson/sound-rawmidi-Add-framing-mode/20210418-231512
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
config: x86_64-randconfig-a001-20210418 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 1c10201d9660c1d6f43a7226ca7381bfa255105d)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # https://github.com/0day-ci/linux/commit/6b82e8d56896a3eb7f9024ae5838c4c3402bc4a4
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review David-Henningsson/sound-rawmidi-Add-framing-mode/20210418-231512
        git checkout 6b82e8d56896a3eb7f9024ae5838c4c3402bc4a4
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>):

>> sound/core/rawmidi.c:1014:19: warning: no previous prototype for function 'get_framing_tstamp' [-Wmissing-prototypes]
   struct timespec64 get_framing_tstamp(struct snd_rawmidi_substream *substream)
                     ^
   sound/core/rawmidi.c:1014:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   struct timespec64 get_framing_tstamp(struct snd_rawmidi_substream *substream)
   ^
   static 
   1 warning generated.


vim +/get_framing_tstamp +1014 sound/core/rawmidi.c

  1013	
> 1014	struct timespec64 get_framing_tstamp(struct snd_rawmidi_substream *substream)
  1015	{
  1016		struct timespec64 ts64 = {0, 0};
  1017	
  1018		if (substream->framing != SNDRV_RAWMIDI_FRAMING_TSTAMP)
  1019			return ts64;
  1020		if (substream->clock_type == CLOCK_MONOTONIC_RAW)
  1021			ktime_get_raw_ts64(&ts64);
  1022		else
  1023			ktime_get_ts64(&ts64);
  1024		return ts64;
  1025	}
  1026	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux