Re: [PATCH] ASoC: codecs: wcd934x: Fix missing IRQF_ONESHOT as only threaded handler

Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx> · Thu, 15 Apr 2021 10:34:21 +0100

On 15/04/2021 08:38, zhuguangqing83@xxxxxxxxx wrote:
From: Guangqing Zhu <zhuguangqing83@xxxxxxxxx>

Coccinelle noticed:
   sound/soc/codecs/wcd934x.c:5041:7-32: ERROR: Threaded IRQ with no primary
handler requested without IRQF_ONESHOT

Signed-off-by: Guangqing Zhu <zhuguangqing83@xxxxxxxxx>
---

Thanks for the patch,

Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>

  sound/soc/codecs/wcd934x.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/codecs/wcd934x.c b/sound/soc/codecs/wcd934x.c
index 5fe403307b72..cddc49bbb7f6 100644
--- a/sound/soc/codecs/wcd934x.c
+++ b/sound/soc/codecs/wcd934x.c
@@ -5040,7 +5040,7 @@ static int wcd934x_codec_probe(struct platform_device *pdev)
  
  	ret = devm_request_threaded_irq(dev, irq, NULL,
  					wcd934x_slim_irq_handler,
-					IRQF_TRIGGER_RISING,
+					IRQF_TRIGGER_RISING | IRQF_ONESHOT,
  					"slim", wcd);
  	if (ret) {
  		dev_err(dev, "Failed to request slimbus irq\n");







