Re: [PATCH] ALSA: control_led - fix the stack usage (control element ops)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 14 Apr 2021 12:58:58 +0200,
Jaroslav Kysela wrote:
> 
> It's a bad idea to allocate big structures on the stack.
> Mark the variables as static and add a note for the locking.
> 
> Fixes: 22d8de62f11b ("ALSA: control - add generic LED trigger module as the new control layer")
> Signed-off-by: Jaroslav Kysela <perex@xxxxxxxx>
> Cc: Nathan Chancellor <nathan@xxxxxxxxxx>
> Cc: Takashi Sakamoto <o-takashi@xxxxxxxxxxxxx>
> Signed-off-by: Jaroslav Kysela <perex@xxxxxxxx>

Applied now (with a removal of the duplicated sign-off).

Thanks!


Takashi



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux