Re: [PATCH v4] sound: rawmidi: Add framing mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 12 Apr 2021 12:03:30 +0200,
Jaroslav Kysela wrote:
> 
> Dne 12. 04. 21 v 11:54 Takashi Iwai napsal(a):
> 
> > And, the patch misses the change in rawmidi_compat.c.  It's also the
> > reason we'd like to avoid the bit fields usage, too.  (Not only that,
> > though.)
> 
> Looking to snd_rawmidi_ioctl_params_compat(), I don't see a difference for a
> version with and without bit fields. In both cases, the value should be copied
> from one structure to another.
> 
> I see other structs in include/uapi which are using bit fields in public ioctl
> calls.

Yes, and those were bad ideas, too.


Takashi



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux