Re: [PATCH 4/4] ASoC: codecs: tlv320aic3x: add SPI support

[Péter Ujfalusi <peter.ujfalusi@xxxxxxxxx>]

Hi,

On 4/7/21 8:44 AM, Jiří Prchal wrote:
> 
> 
> On 06. 04. 21 18:54, Mark Brown wrote:
>> On Tue, Apr 06, 2021 at 04:24:39PM +0200, Jiri Prchal wrote:
>>> Added SPI support.
>>>
>>> Signed-off-by: Jiri Prchal <jiri.prchal@xxxxxxxxxxx>
>>> ---
>>>   sound/soc/codecs/Kconfig           |  7 +++
>>>   sound/soc/codecs/Makefile          |  2 +
>>>   sound/soc/codecs/tlv320aic3x-spi.c | 76 ++++++++++++++++++++++++++++++
>>>   3 files changed, 85 insertions(+)
>>>   create mode 100644 sound/soc/codecs/tlv320aic3x-spi.c
>>
>> This looks good but we should also add an update to the DT binding which
>> notes that SPI is also supported, right now reg is documented as being
>> at an I2C address.
>>
> Mark, please, will you navigate me where DT binding is.

Documentation/devicetree/bindings/sound/tlv320aic3x.txt

> I just added this to my board dts and that's all:
>     spi0: spi@f0000000 {
>     ...
>         // audio codec
>         tlv320aic3106: codec@3 {
>             compatible = "ti,tlv320aic3106";
>             reg = <3>;
>             #sound-dai-cells = <0>;
>             spi-max-frequency = <1000000>;
>             status = "okay";
>             DRVDD-supply = <&reg_3v3>;
>             AVDD-supply = <&reg_3v3>;
>             IOVDD-supply = <&reg_3v3>;
>             DVDD-supply = <&reg_1v8>;
>             ai3x-ocmv = <0>;
>         };

-- 
Péter