On 2021/3/31 6:45, Rob Herring wrote: > On Tue, Mar 30, 2021 at 11:06:30AM +0800, Zhen Lei wrote: >> When I do dt_binding_check, below warning is reported: >> Documentation/devicetree/bindings/sound/renesas,rsnd.example.dt.yaml: \ >> sound@ec500000: 'dais' is a required property >> >> I looked at all the dts files in the "arch/arm64/boot/dts/renesas/" >> directory, I found that all nodes that contain the "dais" property have >> compatible string: "audio-graph-card". So I can be sure that the >> "$ref: audio-graph.yaml#" should be corrected to >> "$ref: audio-graph-card.yaml#". >> >> In addition, not all nodes have compatible string "audio-graph-card", so >> the "$ref: audio-graph-card.yaml#" should be described as "anyOf". To >> ensure the validation of "anyOf" always passes, group it with the "if" >> statement, because the result of the "if" statement is always not empty. > > 'anyOf' is probably not right here. Oh, yes, I think I should use "if" statement to enumerate cases where "audio-graph-card.yaml" is required. > > In any case, the is going to conflict with my series[1]. OK, I'll rework my patch based on your series. > > Rob > > [1] https://lore.kernel.org/r/20210323163634.877511-1-robh@xxxxxxxxxx/ > > . >
