On Thu, Mar 11, 2021 at 10:58:09AM +0800, jack.yu@xxxxxxxxxxx wrote: > From: Jack Yu <jack.yu@xxxxxxxxxxx> > > This is initial amplifier driver for rt1019. > > Signed-off-by: Jack Yu <jack.yu@xxxxxxxxxxx> > --- > .../devicetree/bindings/sound/rt1019.yaml | 33 + Bindings should be a separate patch. checkpatch.pl will tell you this. Bindings should also be sent to the DT list. get_maintainer.pl will tell you this. Now this causes warnings in linux-next: Documentation/devicetree/bindings/sound/rt1019.example.dt.yaml: Warning (pci_device_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/sound/rt1019.example.dt.yaml: Warning (pci_device_bus_num): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/sound/rt1019.example.dt.yaml: Warning (simple_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/sound/rt1019.example.dts:19.13-24.11: Warning (i2c_bus_bridge): /example-0/i2c: incorrect #address-cells for I2C bus Documentation/devicetree/bindings/sound/rt1019.example.dts:19.13-24.11: Warning (i2c_bus_bridge): /example-0/i2c: incorrect #size-cells for I2C bus Documentation/devicetree/bindings/sound/rt1019.example.dt.yaml: Warning (i2c_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/sound/rt1019.example.dt.yaml: Warning (i2c_bus_reg): Failed prerequisite 'i2c_bus_bridge' Documentation/devicetree/bindings/sound/rt1019.example.dt.yaml: Warning (spi_bus_reg): Failed prerequisite 'reg_format' Documentation/devicetree/bindings/sound/rt1019.example.dts:20.30-23.15: Warning (avoid_default_addr_size): /example-0/i2c/codec@28: Relying on default #address-cells value Documentation/devicetree/bindings/sound/rt1019.example.dts:20.30-23.15: Warning (avoid_default_addr_size): /example-0/i2c/codec@28: Relying on default #size-cells value Documentation/devicetree/bindings/sound/rt1019.example.dt.yaml: Warning (unique_unit_address): Failed prerequisite 'avoid_default_addr_size' > sound/soc/codecs/Kconfig | 7 + > sound/soc/codecs/Makefile | 2 + > sound/soc/codecs/rt1019.c | 940 ++++++++++++++++++ > sound/soc/codecs/rt1019.h | 320 ++++++ > 5 files changed, 1302 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/rt1019.yaml > create mode 100644 sound/soc/codecs/rt1019.c > create mode 100644 sound/soc/codecs/rt1019.h