On Sun, Mar 21, 2021 at 4:16 AM Takashi Iwai <tiwai@xxxxxxx> wrote: > > On Sat, 20 Mar 2021 23:23:33 +0100, > Tong Zhang wrote: > > > > This series fixes issues in hdsp and hdspm. The drivers in question want > > to disable a device that is not enabled on error path. > > > > v2: add fix to rme9652 > > > > Tong Zhang (3): > > ALSA: hdsp: don't disable if not enabled > > ALSA: hdspm: don't disable if not enabled > > ALSA: rme9652: don't disable if not enabled > > Thanks for the patches. > > IMO, a safer way for this is to add pci_is_enabled() check in *_free() > functions around the call of pci_disable_device(). The point is that > *_free() is the sole destructor function that manages all stuff, hence > it's better to do all there. And, of course, it'll be less changes. > > Care to resend v3 patches with that? > > > thanks, > > Takashi Thanks Takashi. I made some changes and sent them as v3. - Tong
