Re: [PATCH 1/2] ASoC: rt715: add main capture switch and main capture volume

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Dne 19. 03. 21 v 4:03 Jack Yu napsal(a):
> Add main capture switch and main capture volume control.
> Main capture control has its own channel value respectivelly.

It's a 'deja vu' without a proper solution. Please, resolve issues described
in the first thread:

https://lore.kernel.org/alsa-devel/20201214064903.2746-1-jack.yu@xxxxxxxxxxx/#t

It's bad to map multiple controls to operate on top of the same registers
without any kind of synchronization.

Also, I note that the put callback should return 1 when the value is changed.
Your callbacks return only 0 in all cases.

I would not apply this patch.

						Jaroslav

-- 
Jaroslav Kysela <perex@xxxxxxxx>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux