Re: [PATCH v0] ASoC: rsnd: core: Check convert rate in rsnd_hw_params

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Mikhail

> From: Mikhail Durnev <mikhail_durnev@xxxxxxxxxx>
> 
> snd_pcm_hw_params_set_rate_near can return incorrect sample rate in
> some cases, e.g. when the backend output rate is set to some value higher
> than 48000 Hz and the input rate is 8000 Hz. So passing the value returned
> by snd_pcm_hw_params_set_rate_near to snd_pcm_hw_params will result in
> "FSO/FSI ratio error" and playing no audio at all while the userland
> is not properly notified about the issue.
> 
> If SRC is unable to convert the requested sample rate to the sample rate
> the backend is using, then the requested sample rate should be adjusted in
> rsnd_hw_params. The userland will be notified about that change in the
> returned hw_params structure.
> 
> Signed-off-by: Mikhail Durnev <mikhail_durnev@xxxxxxxxxx>

Thank you for your patch.
Indeed it needs this kind of filter.
Maybe we need to care more in the future, but it is enough so far I think.

	Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>

Thank you for your help !!

Best regards
---
Kuninori Morimoto



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux