On Mon, 15 Mar 2021 16:37:32 +0100, Vitaly Rodionov wrote: > > >> @@ -1881,13 +1896,15 @@ static void cs8409_jack_unsol_event(struct hda_codec *codec, unsigned int res) > >> reg_hs_status = cs8409_i2c_read(codec, CS42L42_I2C_ADDR, 0x1124, 1); > >> reg_ts_status = cs8409_i2c_read(codec, CS42L42_I2C_ADDR, 0x130f, 1); > >> - /* Clear interrupts */ > >> + /* Clear interrupts, by reading interrupt status registers */ > >> cs8409_i2c_read(codec, CS42L42_I2C_ADDR, 0x1b7b, 1); > >> - cs8409_i2c_read(codec, CS42L42_I2C_ADDR, 0x1308, 1); > >> - cs8409_i2c_read(codec, CS42L42_I2C_ADDR, 0x130f, 1); > > Why those two calls are removed? > This 2 call are redundant as we already did read these 2 registers in > a code few lines above. OK, then please either split the patch to address this or mention the change briefly in the commit log. thanks, Takashi
