On Fri, 12 Mar 2021 19:22:28 +0100, Pierre-Louis Bossart wrote: > > Cppcheck warning: > > sound/soc/codecs/cx2072x.c:830:26: style: Variable > 'reg1.r.rx_data_one_line' is reassigned a value before the old one has > been used. [redundantAssignment] > > reg1.r.rx_data_one_line = 1; > ^ > > sound/soc/codecs/cx2072x.c:782:26: note: reg1.r.rx_data_one_line is > assigned > reg1.r.rx_data_one_line = 1; > ^ > > sound/soc/codecs/cx2072x.c:830:26: note: reg1.r.rx_data_one_line is > overwritten > reg1.r.rx_data_one_line = 1; > ^ > > sound/soc/codecs/cx2072x.c:831:26: style: Variable > 'reg1.r.tx_data_one_line' is reassigned a value before the old one has > been used. [redundantAssignment] > reg1.r.tx_data_one_line = 1; > ^ > sound/soc/codecs/cx2072x.c:783:26: note: reg1.r.tx_data_one_line is > assigned > reg1.r.tx_data_one_line = 1; > ^ > > sound/soc/codecs/cx2072x.c:831:26: note: reg1.r.tx_data_one_line is > overwritten > reg1.r.tx_data_one_line = 1; > ^ > > Likely copy/paste. > > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> Reviewed-by: Takashi Iwai <tiwai@xxxxxxx> thanks, Takashi
