On 3/12/21 4:45 AM, Krzysztof Kozlowski wrote:
On 11/03/2021 01:35, Pierre-Louis Bossart wrote:
cppcheck warning:
sound/soc/samsung/tm2_wm5110.c:552:26: style: Local variable 'args'
shadows outer variable [shadowVariable]
struct of_phandle_args args;
^
sound/soc/samsung/tm2_wm5110.c:504:25: note: Shadowed declaration
struct of_phandle_args args;
^
sound/soc/samsung/tm2_wm5110.c:552:26: note: Shadow variable
struct of_phandle_args args;
^
it's not clear why there was a need for a local variable at a lower
scope, remove it and share the same variable between scopes.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
---
sound/soc/samsung/tm2_wm5110.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/samsung/tm2_wm5110.c b/sound/soc/samsung/tm2_wm5110.c
index 125e07f65d2b..c1ab6c3afd0e 100644
--- a/sound/soc/samsung/tm2_wm5110.c
+++ b/sound/soc/samsung/tm2_wm5110.c
@@ -549,7 +549,6 @@ static int tm2_probe(struct platform_device *pdev)
}
for (i = 0; i < num_codecs; i++) {
- struct of_phandle_args args;
ret = of_parse_phandle_with_args(dev->of_node, "i2s-controller",
cells_name, i, &args);
The agreement was to keep it as in v2, so to have two local variables
instead of bigger scope.
Ack, I misunderstood the feedback, will resend.
