11.03.2021 19:32, kernel test robot пишет: > Hi Dmitry, > > I love your patch! Perhaps something to improve: > > [auto build test WARNING on pza/reset/next] > [also build test WARNING on asoc/for-next linus/master v5.12-rc2 next-20210311] > [cannot apply to tegra/for-next] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: https://github.com/0day-ci/linux/commits/Dmitry-Osipenko/Add-missing-reset-controls-to-NVIDIA-Tegra-ASoC-drivers/20210311-231938 > base: https://git.pengutronix.de/git/pza/linux reset/next > config: m68k-defconfig (attached as .config) > compiler: m68k-linux-gcc (GCC) 9.3.0 > reproduce (this is a W=1 build): > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # https://github.com/0day-ci/linux/commit/082cad3274c4566ac97502fd137479791c318300 > git remote add linux-review https://github.com/0day-ci/linux > git fetch --no-tags linux-review Dmitry-Osipenko/Add-missing-reset-controls-to-NVIDIA-Tegra-ASoC-drivers/20210311-231938 > git checkout 082cad3274c4566ac97502fd137479791c318300 > # save the attached .config to linux build tree > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=m68k > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot <lkp@xxxxxxxxx> > > All warnings (new ones prefixed by >>): > > In file included from drivers/net/phy/mdio_bus.c:30: > include/linux/reset.h: In function 'reset_control_bulk_get_exclusive': >>> include/linux/reset.h:215:9: warning: returning 'struct reset_control *' from a function with return type 'int' makes integer from pointer without a cast [-Wint-conversion] > 215 | return __reset_control_bulk_get(dev, num_rstcs, rstcs, false, false, true); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > include/linux/reset.h: In function 'reset_control_bulk_get_exclusive_released': > include/linux/reset.h:257:9: warning: returning 'struct reset_control *' from a function with return type 'int' makes integer from pointer without a cast [-Wint-conversion] > 257 | return __reset_control_bulk_get(dev, num_rstcs, rstcs, false, false, false); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > include/linux/reset.h: In function 'reset_control_bulk_get_optional_exclusive_released': > include/linux/reset.h:278:9: warning: returning 'struct reset_control *' from a function with return type 'int' makes integer from pointer without a cast [-Wint-conversion] > 278 | return __reset_control_bulk_get(dev, num_rstcs, rstcs, false, true, false); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > include/linux/reset.h: In function 'reset_control_bulk_get_shared': > include/linux/reset.h:323:9: warning: returning 'struct reset_control *' from a function with return type 'int' makes integer from pointer without a cast [-Wint-conversion] > 323 | return __reset_control_bulk_get(dev, num_rstcs, rstcs, true, false, false); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > include/linux/reset.h: In function 'reset_control_bulk_get_optional_exclusive': > include/linux/reset.h:360:9: warning: returning 'struct reset_control *' from a function with return type 'int' makes integer from pointer without a cast [-Wint-conversion] > 360 | return __reset_control_bulk_get(dev, num_rstcs, rstcs, false, true, true); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > include/linux/reset.h: In function 'reset_control_bulk_get_optional_shared': > include/linux/reset.h:397:9: warning: returning 'struct reset_control *' from a function with return type 'int' makes integer from pointer without a cast [-Wint-conversion] > 397 | return __reset_control_bulk_get(dev, num_rstcs, rstcs, true, true, false); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > include/linux/reset.h: In function 'devm_reset_control_bulk_get_exclusive': > include/linux/reset.h:522:9: warning: returning 'struct reset_control *' from a function with return type 'int' makes integer from pointer without a cast [-Wint-conversion] > 522 | return __devm_reset_control_bulk_get(dev, num_rstcs, rstcs, false, false, true); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > include/linux/reset.h: In function 'devm_reset_control_bulk_get_exclusive_released': > include/linux/reset.h:561:9: warning: returning 'struct reset_control *' from a function with return type 'int' makes integer from pointer without a cast [-Wint-conversion] > 561 | return __devm_reset_control_bulk_get(dev, num_rstcs, rstcs, false, false, false); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > include/linux/reset.h: In function 'devm_reset_control_bulk_get_optional_exclusive_released': > include/linux/reset.h:600:9: warning: returning 'struct reset_control *' from a function with return type 'int' makes integer from pointer without a cast [-Wint-conversion] > 600 | return __devm_reset_control_bulk_get(dev, num_rstcs, rstcs, false, true, false); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > include/linux/reset.h: In function 'devm_reset_control_bulk_get_shared': > include/linux/reset.h:635:9: warning: returning 'struct reset_control *' from a function with return type 'int' makes integer from pointer without a cast [-Wint-conversion] > 635 | return __devm_reset_control_bulk_get(dev, num_rstcs, rstcs, true, false, false); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > include/linux/reset.h: In function 'devm_reset_control_bulk_get_optional_exclusive': > include/linux/reset.h:673:9: warning: returning 'struct reset_control *' from a function with return type 'int' makes integer from pointer without a cast [-Wint-conversion] > 673 | return __devm_reset_control_bulk_get(dev, num_rstcs, rstcs, true, false, true); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > include/linux/reset.h: In function 'devm_reset_control_bulk_get_optional_shared': > include/linux/reset.h:711:9: warning: returning 'struct reset_control *' from a function with return type 'int' makes integer from pointer without a cast [-Wint-conversion] > 711 | return __devm_reset_control_bulk_get(dev, num_rstcs, rstcs, true, true, false); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > vim +215 include/linux/reset.h > > 200 > 201 /** > 202 * reset_control_bulk_get_exclusive - Lookup and obtain exclusive references to > 203 * multiple reset controllers. > 204 * @dev: device to be reset by the controller > 205 * @num_rstcs: number of entries in rstcs array > 206 * @rstcs: array of struct reset_control_bulk_data with reset line names set > 207 * > 208 * Fills the rstcs array with pointers to exclusive reset controls and > 209 * returns 0, or an IS_ERR() condition containing errno. > 210 */ > 211 static inline int __must_check > 212 reset_control_bulk_get_exclusive(struct device *dev, int num_rstcs, > 213 struct reset_control_bulk_data *rstcs) > 214 { > > 215 return __reset_control_bulk_get(dev, num_rstcs, rstcs, false, false, true); > 216 } > 217 > > --- > 0-DAY CI Kernel Test Service, Intel Corporation > https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx > I missed to check the !CONFIG_RESET_CONTROLLER case, will make a v3.
