Re: [PATCH 10/10] ASoC: wm_hubs: align function prototype

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 10, 2021 at 06:43:32PM -0600, Pierre-Louis Bossart wrote:
> cppcheck warnings:
> 
> sound/soc/codecs/wm_hubs.c:1194:11: style:inconclusive: Function
> 'wm_hubs_handle_analogue_pdata' argument 8 names different:
> declaration 'micbias1_dly' definition
> 'micbias1_delay'. [funcArgNamesDifferent]
>       int micbias1_delay, int micbias2_delay,
>           ^
> sound/soc/codecs/wm_hubs.h:59:11: note: Function
> 'wm_hubs_handle_analogue_pdata' argument 8 names different:
> declaration 'micbias1_dly' definition 'micbias1_delay'.
>       int micbias1_dly, int micbias2_dly,
>           ^
> sound/soc/codecs/wm_hubs.c:1194:11: note: Function
> 'wm_hubs_handle_analogue_pdata' argument 8 names different:
> declaration 'micbias1_dly' definition 'micbias1_delay'.
>       int micbias1_delay, int micbias2_delay,
>           ^
> sound/soc/codecs/wm_hubs.c:1194:31: style:inconclusive: Function
> 'wm_hubs_handle_analogue_pdata' argument 9 names different:
> declaration 'micbias2_dly' definition
> 'micbias2_delay'. [funcArgNamesDifferent]
>       int micbias1_delay, int micbias2_delay,
>                               ^
> sound/soc/codecs/wm_hubs.h:59:29: note: Function
> 'wm_hubs_handle_analogue_pdata' argument 9 names different:
> declaration 'micbias2_dly' definition 'micbias2_delay'.
>       int micbias1_dly, int micbias2_dly,
>                             ^
> sound/soc/codecs/wm_hubs.c:1194:31: note: Function
> 'wm_hubs_handle_analogue_pdata' argument 9 names different:
> declaration 'micbias2_dly' definition 'micbias2_delay'.
>       int micbias1_delay, int micbias2_delay,
>                               ^
> 
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
> ---

Acked-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>

Thanks,
Charles



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux