Re: [PATCH 04/10] ASoC: wm8903: remove useless assignments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 10, 2021 at 06:43:26PM -0600, Pierre-Louis Bossart wrote:
> cppcheck warnings:
> 
> sound/soc/codecs/wm8903.c:1552:11: style: Variable 'best_val' is
> assigned a value that is never used. [unreadVariable]
>  best_val = ((clk_sys * 10) / bclk_divs[0].ratio) - bclk;
>           ^
> sound/soc/codecs/wm8903.c:1559:12: style: Variable 'best_val' is
> assigned a value that is never used. [unreadVariable]
>   best_val = cur_val;
>            ^
> 
> Indeed what matters in the code is the blck_div, the best_val is
> assigned but never tested or used.
> 
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
> ---

Acked-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>

Thanks,
Charles



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux