Re: [PATCH 6/8] ASoC: soc-pcm: fixup dpcm_be_dai_startup() user count

Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> · Fri, 5 Mar 2021 10:14:00 -0600

On 3/4/21 7:00 PM, Kuninori Morimoto wrote:

From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>

At dpcm_be_dai_startup_unwind(), it indicates error message at (1)
if this function was called with no users.
But, it doesn't use "continue" here. Thus, it will be minus
users at (2).

suggested edit:

"Thus, users will be a negative number at (2)"

	void dpcm_be_dai_startup_unwind(...)
	{
		...
		for_each_dpcm_be(...) {
			...
(1)			if (be->dpcm[stream].users == 0)
				dev_err(...);

(2)			if (--be->dpcm[stream].users != 0)
				continue;