Hi, On 3/5/21 10:57 AM, Jaroslav Kysela wrote: > Dne 04. 03. 21 v 22:50 Hans de Goede napsal(a): >> Hi All, >> >> On 2/28/21 5:13 PM, Hans de Goede wrote: >>> Hi All, >>> >>> Here is v2 of my series of alsa-lib volume-control fixes which I wrote >>> while working on adding hw-volume control to UCM profiles for various >>> x86 ASoC setups. >>> >>> New in v2 is adding an extra entry to the capture_volume_names array >>> for the "ADC PGA Gain Volume" control used in the es8316 codec driver >>> in patch 3/3. >>> >>> Note that patch 3/3 is not strictly necessary to make hw-volume control >>> work. At least the PA hw-vol-control code does not care if the controls >>> are wronly marked as global-volume-controls instead of >>> capture-volume-controls. I mostly wrote patch 3/3 because for >>> correctness reasons, so if it is deemed controversial we can drop it. >> >> Self-nack, I have some plans to make this more generic and I found >> another set of control-names which need special handling (which is >> the motivation to make the exception mechanism more generic). > > I think that we should put the exceptions to a configuration file per driver, > but I haven't a time to propose a complete solution. Yes that would be ideal. But I don't have the time for that either. What I do have in mind should be able to serve as a basis for that. > BTW: The first patch looks really straight, so I have a plan to merge it. That is fine, my planned re-write of this patch-set starts at patch 2 :) Regards, Hans
