Re: [PATCH v2 1/5] soundwire: qcom: add support to missing transport params

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




soundwire-controller@3210000 {
     reg = <0 0x3210000 0 0x2000>;
     compatible = "qcom,soundwire-v1.5.1";
     interrupts = <GIC_SPI 298 IRQ_TYPE_LEVEL_HIGH>;
     clocks = <&rxmacro>;
     clock-names = "iface";
     qcom,clock-stop-mode0;
     qcom,din-ports = <0>;
     qcom,dout-ports = <5>;

     qcom,ports-sinterval-low = /bits/ 8 <0x03 0x1F 0x1F 0x07 0x00>;
     qcom,ports-offset1 = /bits/ 8 <0x00 0x00 0x0B 0x01 0x00>;
     qcom,ports-offset2 = /bits/ 8 <0x00 0x00 0x0B 0x00 0x00>;
     qcom,ports-hstart = /bits/ 8 <0xFF 0x03 0xFF 0xFF 0xFF>;
     qcom,ports-hstop = /bits/ 8 <0xFF 0x06 0xFF 0xFF 0xFF>;
     qcom,ports-word-length = /bits/ 8 <0x01 0x07 0x04 0xFF 0xFF>;
     qcom,ports-block-pack-mode = /bits/ 8 <0xFF 0x00 0x01 0xFF 0xFF>;
     qcom,ports-lane-control = /bits/ 8 <0x01 0x00 0x00 0x00 0x00>;
     qcom,ports-block-group-count = /bits/ 8 <0xFF 0xFF 0xFF 0xFF 0x00>;

     #sound-dai-cells = <1>;
     #address-cells = <2>;
     #size-cells = <0>;
};
properties that may or may not be valid. If this is intentional and desired, this should still be captured somehow, e.g. in the bindings documentation or in the code with a comment, no?

Yes, I agree with you on this, I should document this in bindings!

thanks for the explanations, it'd be useful indeed to document what this magic 0xFF value means.




[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux