Re: [PATCH] ALSA: hda - bind headset buttons to the headphone jack

[Hui Wang <hui.wang@xxxxxxxxxxxxx>]

On 3/3/21 4:46 PM, Takashi Iwai wrote:
> On Wed, 03 Mar 2021 02:23:46 +0100,
> Hui Wang wrote:
> > With the HDA driver, if the headset buttons are supported, an audio
[snip]
> > +
> >   	jack->jack->button_state = report;
> >   }
> I think this part should be rather in hda_jack.c, e.g. create a function
> snd_hda_jack_set_button_state() and handle the redirection there.
> It's not good to change the content in jack->jack externally.

OK, got it. will change it.

Thanks.

> thanks,
>
> Takashi